Skip to content

update to k8s 1.33 #917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2025
Merged

Conversation

kannon92
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Update scheduler plugins to k8s 1.33.

The major update was to use NodeInfo rather than NodeName.

Which issue(s) this PR fixes:

Fixes #916

Special notes for your reviewer:

Does this PR introduce a user-facing change?

update dependencies to 1.33

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jul 27, 2025
@k8s-ci-robot k8s-ci-robot requested review from Tal-or and zwpaper July 27, 2025 16:38
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 27, 2025
Copy link

netlify bot commented Jul 27, 2025

Deploy Preview for kubernetes-sigs-scheduler-plugins canceled.

Name Link
🔨 Latest commit 0404cc6
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-scheduler-plugins/deploys/6895141791413a00097b1908

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 27, 2025
@kannon92
Copy link
Contributor Author

I think http://github.com/kubernetes/test-infra/pull/35229 needs to merge first.

@kannon92
Copy link
Contributor Author

/retest

@tenzen-y
Copy link
Member

Before we upgrade this dependency version, we need to release scheduler-plugins v0.32.x.

@kannon92
Copy link
Contributor Author

/hold

I created #918

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 27, 2025
@Huang-Wei
Copy link
Contributor

/hold

I will cut a 0.32 release first (ETA next week)

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 31, 2025
@kannon92
Copy link
Contributor Author

Thank you @Huang-Wei!

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 1, 2025
@Huang-Wei Huang-Wei mentioned this pull request Aug 7, 2025
10 tasks
@Huang-Wei
Copy link
Contributor

@kannon92 release 0.32.7 has been cut (#927). Optionally, you can rebase this PR with master, and next we're ready to merge and cut a 0.33.3-devel tag.

@kannon92
Copy link
Contributor Author

kannon92 commented Aug 7, 2025

@kannon92 release 0.32.7 has been cut (#927). Optionally, you can rebase this PR with master, and next we're ready to merge and cut a 0.33.3-devel tag.

done.

@kannon92
Copy link
Contributor Author

kannon92 commented Aug 8, 2025

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 8, 2025
@googs1025
Copy link
Member

googs1025 commented Aug 8, 2025

/lgtm
thanks for this 😄

just one nit

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2025
Copy link
Contributor

@Huang-Wei Huang-Wei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Huang-Wei, kannon92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2025
@k8s-ci-robot k8s-ci-robot merged commit c88848c into kubernetes-sigs:master Aug 9, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Kubernetes dependencies to 0.33
5 participants